FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.8

Threshold is Low

Effort is Default

Summary

Classes Bugs Errors Missing Classes
327 45 0 0

fit.ActionFixture

Bug Category Details Line Priority
fit.ActionFixture.actor should be package protected MALICIOUS_CODE MS_PKGPROTECT Not available Medium
fit.ActionFixture.empty isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 11 Medium
Write to static field fit.ActionFixture.actor from instance method fit.ActionFixture.start() STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 28 High

fit.FileRunner

Bug Category Details Line Priority
fit.FileRunner.main(String[]) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 27 Low
fit.FileRunner.args(String[]) invokes System.exit(...), which shuts down the entire virtual machine BAD_PRACTICE DM_EXIT 68 Medium
Method fit.FileRunner.read(File) may fail to clean up stream or resource of type java.io.Reader EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION 82 Medium
fit.FileRunner.read(File) may fail to close stream on exception BAD_PRACTICE OS_OPEN_STREAM_EXCEPTION_PATH 82 Low
fit.FileRunner.read(File) ignores result of java.io.FileReader.read(char[]) BAD_PRACTICE RR_NOT_CHECKED 83 Low

fit.Fixture

Bug Category Details Line Priority
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 264 Low
fit.Fixture.getArgs() may expose internal representation by returning Fixture.args MALICIOUS_CODE EI_EXPOSE_REP 312 Medium
Method fit.Fixture.getArgsForTable(Parse) uses Collection.toArray() with zero-length array argument PERFORMANCE ITA_INEFFICIENT_TO_ARRAY 147 Low
fit.Fixture.gray isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 188 High
fit.Fixture.green isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 186 High
fit.Fixture.red isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 187 High
fit.Fixture.yellow isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 189 High
Exception is caught when Exception is not thrown in fit.Fixture.check(Parse, TypeAdapter) STYLE REC_CATCH_EXCEPTION 282 Low

fit.Fixture$RunTime

Bug Category Details Line Priority
Should fit.Fixture$RunTime be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 31-47 Medium

fit.Parse

Bug Category Details Line Priority
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 41 Low
fit.Parse.tags should be both final and package protected MALICIOUS_CODE MS_FINAL_PKGPROTECT 30 Medium
fit.Parse.footnoteFiles should be package protected MALICIOUS_CODE MS_PKGPROTECT 219 Medium
fit.Parse.footnote() ignores exceptional return value of java.io.File.delete() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 228 Medium

fit.PrimitiveFixture

Bug Category Details Line Priority
Test for floating point equality in fit.PrimitiveFixture.check(Parse, double) STYLE FE_FLOATING_POINT_EQUALITY 42 Low

fit.RowFixture

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in fit.RowFixture.cSort(List, int) STYLE REC_CATCH_EXCEPTION 103 Low

fit.ScientificDouble

Bug Category Details Line Priority
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 31 Low
fit.ScientificDouble.equals(Object) is unusual STYLE EQ_UNUSUAL 43 Medium
fit.ScientificDouble defines equals and uses Object.hashCode() BAD_PRACTICE HE_EQUALS_USE_HASHCODE 43 High
fit.ScientificDouble is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 12-75 Low

fit.Summary

Bug Category Details Line Priority
fit.Summary.countsKey isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 9 High

fit.TypeAdapter$ClassBooleanAdapter

Bug Category Details Line Priority
fit.TypeAdapter$ClassBooleanAdapter.parse(String) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead PERFORMANCE DM_BOOLEAN_CTOR 207 Medium

fit.TypeAdapter$ClassByteAdapter

Bug Category Details Line Priority
Method fit.TypeAdapter$ClassByteAdapter.parse(String) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead PERFORMANCE DM_NUMBER_CTOR 117 Medium

fit.TypeAdapter$ClassCharacterAdapter

Bug Category Details Line Priority
Method fit.TypeAdapter$ClassCharacterAdapter.parse(String) invokes inefficient new Character(char) constructor; use Character.valueOf(char) instead PERFORMANCE DM_NUMBER_CTOR 195 Medium

fit.TypeAdapter$ClassDoubleAdapter

Bug Category Details Line Priority
Method fit.TypeAdapter$ClassDoubleAdapter.parse(String) invokes inefficient Double.valueOf(double) constructor; use TypeAdapter.java:[line 183] instead PERFORMANCE DM_FP_NUMBER_CTOR 183 Low

fit.TypeAdapter$ClassFloatAdapter

Bug Category Details Line Priority
Method fit.TypeAdapter$ClassFloatAdapter.parse(String) invokes inefficient Float.valueOf(float) constructor; use TypeAdapter.java:[line 168] instead PERFORMANCE DM_FP_NUMBER_CTOR 168 Low

fit.TypeAdapter$ClassIntegerAdapter

Bug Category Details Line Priority
Method fit.TypeAdapter$ClassIntegerAdapter.parse(String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 141 Medium

fit.TypeAdapter$ClassLongAdapter

Bug Category Details Line Priority
Method fit.TypeAdapter$ClassLongAdapter.parse(String) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 153 Medium

fit.TypeAdapter$ClassShortAdapter

Bug Category Details Line Priority
Method fit.TypeAdapter$ClassShortAdapter.parse(String) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 129 Medium

fit.TypeAdapter$DoubleAdapter

Bug Category Details Line Priority
Method fit.TypeAdapter$DoubleAdapter.parse(String) invokes inefficient Double.valueOf(double) constructor; use TypeAdapter.java:[line 177] instead PERFORMANCE DM_FP_NUMBER_CTOR 177 Low

fit.TypeAdapter$FloatAdapter

Bug Category Details Line Priority
Method fit.TypeAdapter$FloatAdapter.parse(String) invokes inefficient Float.valueOf(float) constructor; use TypeAdapter.java:[line 162] instead PERFORMANCE DM_FP_NUMBER_CTOR 162 Low

net.sourceforge.xmlfit.fit.stepper.gui.DebuggerFrame

Bug Category Details Line Priority
Synchronization on Boolean could deadlock in net.sourceforge.xmlfit.fit.stepper.gui.DebuggerFrame.fortsetzen() MT_CORRECTNESS DL_SYNCHRONIZATION_ON_BOOLEAN 169 High
Synchronization on Boolean could deadlock in net.sourceforge.xmlfit.fit.stepper.gui.DebuggerFrame.warten() MT_CORRECTNESS DL_SYNCHRONIZATION_ON_BOOLEAN 155 High
Naked notify in net.sourceforge.xmlfit.fit.stepper.gui.DebuggerFrame.fortsetzen() MT_CORRECTNESS NN_NAKED_NOTIFY 171 Medium
Unconditional wait in net.sourceforge.xmlfit.fit.stepper.gui.DebuggerFrame.warten() MT_CORRECTNESS UW_UNCOND_WAIT 158 Medium
Wait not in loop in net.sourceforge.xmlfit.fit.stepper.gui.DebuggerFrame.warten() MT_CORRECTNESS WA_NOT_IN_LOOP 158 Medium

net.sourceforge.xmlfit.fit.stepper.gui.DebuggerViewModel

Bug Category Details Line Priority
Dead store to object in net.sourceforge.xmlfit.fit.stepper.gui.DebuggerViewModel.clean(Object[][]) STYLE DLS_DEAD_LOCAL_STORE 45 Low
net.sourceforge.xmlfit.fit.stepper.gui.DebuggerViewModel.initData(ArrayList) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead PERFORMANCE DM_BOOLEAN_CTOR 31 Medium